Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib-networking for TLS/SSL network (https://) in xwidget #82853

Merged
merged 2 commits into from Mar 18, 2020
Merged

glib-networking for TLS/SSL network (https://) in xwidget #82853

merged 2 commits into from Mar 18, 2020

Conversation

sepiabrown
Copy link
Contributor

@sepiabrown sepiabrown commented Mar 18, 2020 •
edited

ea5bcb7#r31513119
He accidently errased the glib-networking.
But it is needed for TLS/SSL networking.

Motivation for this change

glib-networking for TLS/SSL network (https://) in xwidget

Things done

recovered codes for glib-networking

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sepiabrown
glib-networking for TLS/SSL network (https://) in xwidget
a995651 
ea5bcb7#r31513119
He accidently errased the glib-networking.
But it is needed for TLS/SSL networking.
@matthewbauer matthewbauer merged commit bd15dfa into NixOS:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis adisbladis is a code owner

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sepiabrown @matthewbauer