Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] buildRustPackage: enable strictDeps #82852

Merged
merged 18 commits into from Mar 29, 2020
Merged

[WIP] buildRustPackage: enable strictDeps #82852

merged 18 commits into from Mar 29, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 18, 2020 •
edited

This will improve cross-compiling support by forcing
users to specify buildInputs/nativeBuildInputs correctly.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from andir as a code owner March 18, 2020 13:51
@Mic92
Copy link
Member Author

Mic92 commented Mar 18, 2020

cc @Ericson2314

@Mic92 Mic92 changed the title buildRustPackage: enable strictDeps [WIP] buildRustPackage: enable strictDeps Mar 18, 2020
@Mic92
Copy link
Member Author

Mic92 commented Mar 18, 2020

Let me have a look what this change breaks.

@lovesegfault
Copy link
Member

@Mic92 Any updates on this?

@Mic92
Copy link
Member Author

Mic92 commented Mar 28, 2020

I was finished my buildGoPackage/buildGoModule prs first. This one is next on the list, but take a bit longer, as it rebuilds more packages.

@lovesegfault
Copy link
Member

Got it, I am testing this on my server as well.

@lovesegfault
Copy link
Member

Alright, here's my results:

62 package marked as broken and skipped:
AgdaSheaves TotalParserCombinators agdaBase autotrace bitvector categories epsxe fast-neural-doodle gimpPlugins.exposureBlend gimpPlugins.focusblur gimpPlugins.texturize gitAndTools.git-dit gtk-sharp-3_0 hhvm hyper-haskell idutils intec
ture-cli invoice2data k9copy loadcaffe mapmap mikutter monodevelop natron neural-style notify-sharp openmodelica photoflow polkadot pretty python37Packages.blaze python37Packages.odo python38Packages.arviz python38Packages.blaze python3
8Packages.odo python38Packages.optuna python38Packages.rl-coach rabbitvcs sit synfigstudio torch torch-hdf5 transcribe vimPlugins.youcompleteme vimiv xfce.xfce4-dict-plugin xfce.xfce4-eyes-plugin xfce.xfce4-fsguard-plugin xfce.xfce4-gen
mon-plugin xfce.xfce4-mailwatch-plugin xfce.xfce4-mpc-plugin xfce.xfce4-notes-plugin xfce.xfce4-timer-plugin xfce.xfce4-vala-panel-appmenu-plugin xfce.xfce4_dict_plugin xfce.xfce4_eyes_plugin xfce.xfce4_fsguard_plugin xfce.xfce4_genmon_
plugin xfce.xfce4_mailwatch_plugin xfce.xfce4_mpc_plugin xfce.xfce4_notes_plugin xfce.xfce4_timer_plugin

60 package failed to build:
AgdaStdlib agdaIowaStdlib amp cargo-download cargo-update cedille citrix_workspace citrix_workspace_19_10_0 citrix_workspace_19_6_0 citrix_workspace_19_8_0 contrast fluidasserts fluxus fractal geeqie gencfsm gnome-builder gnome-podcasts
 httplz hydra-cli ib-controller jucipp jwm khal luxcorerender mopidy-mopify mopidy-musicbox-webclient mopidy-soundcloud mopidy-spotify-tunigo mopidy-youtube nasc navit newsboat nix-du obs-ndi panopticon parallel-rust parinfer-rust ping
python37Packages.arviz python37Packages.dask-jobqueue python37Packages.datashader python37Packages.intake python37Packages.rl-coach sequoia python37Packages.streamz python37Packages.stumpy python37Packages.sunpy python38Packages.dask-jo
bqueue python38Packages.datashader python38Packages.intake python38Packages.sequoia python38Packages.streamz rink ripasso-cursive stm32cubemx tensorman uutils-coreutils vdirsyncer vector

@Mic92
Copy link
Member Author

Mic92 commented Mar 29, 2020

Interesting. I had a lot more failures on my machine. Your list looks easier to process to begin with.

@lovesegfault
Copy link
Member

@Mic92 A lot of the rebuilds this triggers have spurious failures, I got to that list after re-running nixpkgs-review some 10 times :D

@Mic92
Copy link
Member Author

Mic92 commented Mar 29, 2020

These are all packages fixed that did fail with strict deps on. There are some packages broken that were already broken before.

@Mic92
Copy link
Member Author

Mic92 commented Mar 29, 2020

@GrahamcOfBorg build hydra-cli

@Mic92 Mic92 merged commit d04396d into NixOS:master Mar 29, 2020
@Mic92 Mic92 deleted the cross-build-rust-package branch March 29, 2020 13:07
@Mic92
Copy link
Member Author

Mic92 commented Mar 29, 2020

I will master into staging together with the buildRustPackage patch that enable strict deps.

@Mic92
Copy link
Member Author

Mic92 commented Mar 29, 2020

strict deps are enabled in e8323a0

@Mic92 Mic92 mentioned this pull request Jun 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @lovesegfault