Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuel angular momentum is lost as-is only from SRMs #2500

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

eggrobin
Copy link
Member

Other engines should also lose some angular momentum, but since liquid fuels go through pipes and injectors they should lose some of their angular momentum before they leave the rocket. This will be addressed in a future pull request.

@@ -74,6 +74,10 @@ class Part final {
Mass const& mass() const;
void set_inertia_tensor(InertiaTensor<RigidPart> const& inertia_tensor);
InertiaTensor<RigidPart> const& inertia_tensor() const;
// Whether this part is a solid rocket motor, whose lost mass is expelled with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... the lost mass of which ...

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this is fine.

Sorry, something went wrong.

@pleroy pleroy added the LGTM label Mar 17, 2020
@eggrobin eggrobin merged commit 7ef1374 into mockingbirdnest:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants