Update and add some Octoprint plugins #80057
Conversation
| @@ -168,13 +168,13 @@ let | |||
|
|
|||
| printtimegenius = buildPlugin rec { | |||
| pname = "PrintTimeGenius"; | |||
| version = "2.0.2"; | |||
| version = "2.2.1"; | |||
There was a problem hiding this comment.
In case you didn't notice: typically you also need to update the marlin-calc package to the version listed here: https://github.com/eyal0/OctoPrint-PrintTimeGenius/tree/master/octoprint_PrintTimeGenius/analyzers
This time there have been no changes to marlin-calc (except for adding a windows cross build target, which doesn't concern us at all), so you're fine.
There was a problem hiding this comment.
Oh ok, thanks for the heads up.
| plugin_requires = ["OctoPrint>=1.3.9rc1", "psutil", "sarge"] | ||
| -from sys import version_info | ||
| -if version_info[0] < 3: | ||
| - plugin_requires.append("logging") |
There was a problem hiding this comment.
Why do we need to disable the logging package?
There was a problem hiding this comment.
They added these lines because of this issue:
eyal0/OctoPrint-PrintTimeGenius#176
However, in our environment, "logging" isn't a package and thus can't be found, so it breaks the build. (It's in the Python standard library.) I don't think that removing these lines actually disables logging, I think it just removes its requirement as a plugin.
Motivation for this change
I wanted these packages
Things done
Added ABL_Expert, GcodeEditor, and SimpleEmergencyStop.
Updated PrintTImeGenius to latest version.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)@gebner
@abbradar
@peterhoeg