[Image-Orientation] Fix canvas drawImage #21788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image orientation was not correctly applied in base_rendering_context_2d,
resulting in always oriented images sometimes drawn with the wrong source
rect. This change fixes that.
The image-orientation setting we respect always comes from the canvas
into which the image is being drawn. This keeps the rules for which
orientation to apply simple.
As part of this change, orientation is added to StaticBitmapImage and
used in the necessary cases to track the orientation of the source
image.
As part of this change, the code to correct an image source rect is
moved to Image and callers updated.
Bug: 1043790
Change-Id: I13d74b66cff912382f8f5efe0050eae6a0f283c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044050
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741635}