Revert "Remove inDocument check for emitting change events" #21789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 13, 2020
This reverts commit 07d811aaeb0724d0d019b8d6bdba3d5de1dc9a5e. The change this reverts fixed http://crbug.com/773680 which was intended to fire change events for detached radio and checkbox input elements when using input.dispatchEvent(new MouseEvent('click')), but also caused input.click() to fire change events. Although these may seem to be the same thing, firefox actually fires change events on input.dispatchEvent but not input.click(). WebKit, and chrome before the patch this reverts fire change events in neither of these cases. I will file an html spec issue to address this compat issue. For now, it seems important to stop firing these change events because it is getting more attention than the lack of change events. Bug: 773680, 1051482 Change-Id: Ia8217d34bf9a20c50ce008630e748a7dbda52c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055590 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#741251}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2055590
branch
from
c4d5680
to
ce887ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 07d811aaeb0724d0d019b8d6bdba3d5de1dc9a5e.
The change this reverts fixed http://crbug.com/773680 which was intended
to fire change events for detached radio and checkbox input elements
when using input.dispatchEvent(new MouseEvent('click')), but also caused
input.click() to fire change events. Although these may seem to be the
same thing, firefox actually fires change events on input.dispatchEvent
but not input.click(). WebKit, and chrome before the patch this reverts
fire change events in neither of these cases.
I will file an html spec issue to address this compat issue. For now, it
seems important to stop firing these change events because it is getting
more attention than the lack of change events.
Bug: 773680, 1051482
Change-Id: Ia8217d34bf9a20c50ce008630e748a7dbda52c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055590
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741251}