Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refind: 0.11.4 -> 0.11.5 #80059

Merged
merged 2 commits into from Feb 16, 2020
Merged

refind: 0.11.4 -> 0.11.5 #80059

merged 2 commits into from Feb 16, 2020

Conversation

samueldr
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from AndersonTorres February 13, 2020 22:01
lsix
lsix reviewed Feb 16, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested.

All good for me.

Thanks!

@lsix lsix merged commit 82945f3 into NixOS:master Feb 16, 2020
@samueldr samueldr deleted the update/refind/0.11.5 branch February 16, 2020 18:16
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 16, 2020
@lsix @dtzWill
Merge pull request NixOS#80059 from samueldr/update/refind/0.11.5
00f254f 
refind: 0.11.4 -> 0.11.5
(cherry picked from commit 82945f3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix left review comments

@betaboon betaboon Awaiting requested review from betaboon

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samueldr @lsix