Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mopidy-mpd: init at version 3.0.0 #80000

Merged
merged 1 commit into from Mar 18, 2020
Merged

mopidy-mpd: init at version 3.0.0 #80000

merged 1 commit into from Mar 18, 2020

Conversation

Tomahna
Copy link
Contributor

@Tomahna Tomahna commented Feb 13, 2020

Motivation for this change

It looks like that since version 3.0.0, Mopidy has separated it's mpd functionality to a separate library.

Things done

Add mopidy-mpd package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata
Copy link
Member

mmilata commented Feb 17, 2020

Probably overlaps with #78361 :/

@Tomahna
Copy link
Contributor Author

Tomahna commented Feb 18, 2020

You're right. I'll close this one.

@Tomahna Tomahna closed this Feb 18, 2020
@jpotier
Copy link
Contributor

jpotier commented Feb 27, 2020

@mmilata @Tomahna with the rate of progress of #78361 I think it's more important that mopidy remains usable with mpd client in the meantime. I'm following unstable, and without this PR I am left to wait for the other PR to go through, and cannot use mopidy anymore (!)

This PR is easy to review and merge comparatively.

Please reopen.

@Tomahna Tomahna reopened this Feb 27, 2020
@Tomahna
Copy link
Contributor Author

Tomahna commented Feb 27, 2020

Done.

jpotier
jpotier approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@jpotier jpotier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonringer
jonringer reviewed Mar 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/applications/audio/mopidy/mpd.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/mopidy/mpd.nix Show resolved Hide resolved
jonringer
jonringer reviewed Mar 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be a python package? I don't see any applications being published:

$ tree -L 3 ./results/mopidy-mpd
./results/mopidy-mpd
├── lib
│   └── python3.7
│       └── site-packages
└── nix-support
    └── propagated-build-inputs

@Tomahna
Copy link
Contributor Author

Tomahna commented Mar 18, 2020 •
edited

It is a python library that you bundle with mopidy to add the mpd server functionality.

The important part is located in the site-packages folder. It is not a standalone application.

@jonringer
Copy link
Contributor

The important part is located in the site-packages folder. It is not a standalone application.

Sounds like they should have been included in python-modules, and mopidy would have an option of doing something like: mopidy.withPlugins(ps: with ps; [ mpd iris ... ]); to ensure they are they are all using the same python interpreter version and get symlinkjoin'd into the same directory (similar to a venv). As it stands, the buildPythonPackage format is "leaking" the packages into the user environment through shellHooks. But it looks like that ship has already sailed.

@jonringer jonringer merged commit 3d846aa into NixOS:master Mar 18, 2020
@jonringer
Copy link
Contributor

looks like my concerns are being addressed in #82651

@Tomahna
Copy link
Contributor Author

Tomahna commented Mar 19, 2020

Thank you, i'll look into it to update a few extensions accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpotier jpotier jpotier approved these changes

@jonringer jonringer jonringer approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tomahna @mmilata @jpotier @jonringer