[Gecko Bug 1604140] Part 1: Fix focus trap within shadow DOM when host is scrollable #21775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 13, 2020
The checks for `*TopLevelScopeOwner` are to skip the scope that we have already checked. But when the shadow host is scrollable, we will traverse anonymous children for the scroll frame first in frame traversal and `oldTopLevelScopeOwner` will be reset. Then we don't realize that we have already checked the host's scope. Differential Revision: https://phabricator.services.mozilla.com/D60923 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1604140 gecko-commit: 241851c7036fd3d3680e35f04a4b93a7faca1a69 gecko-integration-branch: autoland gecko-reviewers: smaug
The original check, `currentContent != startContent`, is to skip the element we started on in frame traversal. This would happen for instance on a scrollable element, where frame traversal could return the element again. However, in shadow dom case, the frame traversal may start on a redirected shadow host, where `startContent` is still the original start element. Differential Revision: https://phabricator.services.mozilla.com/D61566 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1604140 gecko-commit: 0af4f0491ba35d349497b7e539118edc3d040eef gecko-integration-branch: autoland gecko-reviewers: smaug
moz-wptsync-bot
force-pushed
the
gecko/1604140
branch
from
aa30783
to
578ae78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks for
*TopLevelScopeOwnerare to skip the scope that we have already checked.But when the shadow host is scrollable, we will traverse anonymous children for the scroll frame first in frame traversal and
oldTopLevelScopeOwnerwill be reset.Then we don't realize that we have already checked the host's scope.
Differential Revision: https://phabricator.services.mozilla.com/D60923
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1604140
gecko-commit: 8897a2187a9537310df8b283f65844fe46ad075d
gecko-integration-branch: autoland
gecko-reviewers: smaug