Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quake3e: 2019-11-29 -> 2020-01-23 #79999

Merged
merged 1 commit into from Feb 16, 2020
Merged

quake3e: 2019-11-29 -> 2020-01-23 #79999

merged 1 commit into from Feb 16, 2020

Conversation

pmiddend
Copy link
Contributor

Motivation for this change

Regular update. I've tested this by starting the game and playing a round.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[3 built, 1 copied (0.0 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79999
1 package built:
quake3e

@jonringer
Copy link
Contributor

actually, do you mind adding:

  meta = {
    ...
   badPlatforms = [ lib.platforms.aarch64 ];

to prevent hydra trying to build this

@pmiddend
Copy link
Contributor Author

@jonringer Thanks for the suggestion, I added the badPlatforms bit.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build quake3e

@jonringer jonringer merged commit 4ebe020 into NixOS:master Feb 16, 2020
@pmiddend pmiddend deleted the quake3e-2020-01-23 branch February 16, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmiddend @jonringer