Skip to content

elisa: move into kdeApplications #80003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

elisa: move into kdeApplications #80003

merged 1 commit into from
Apr 7, 2020
+48 −40

Conversation

peterhoeg
Copy link
Member

Motivation for this change

elisa is now part of the upstream kdeApplications bundle

We should however not merge this until kde applications 19.12.2 hits master as this PR would otherwise downgrade elisa.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@peterhoeg peterhoeg requested a review from ttuegel as a code owner February 13, 2020 10:19
@ofborg ofborg bot added 6.topic: qt/kde 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 13, 2020
@peterhoeg
elisa: move into kdeApplications
0c7ec50 
elisa is now part of the upstream kdeApplications bundle
@peterhoeg
Copy link
Member Author

Merging since #83897 was merged.

@peterhoeg peterhoeg merged commit d7b9812 into NixOS:master Apr 7, 2020
@peterhoeg peterhoeg deleted the f/elisa branch April 7, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel

@doronbehar doronbehar

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @ttuegel @doronbehar