Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crun: run tests and show the proper version number #80004

Merged
merged 1 commit into from Feb 23, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

crun didn't show the proper version number and we disabled tests as most of them would fail due to our sandbox. At least run some of them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg merged commit e17dff1 into NixOS:master Feb 23, 2020
@peterhoeg peterhoeg deleted the f/crun branch February 23, 2020 13:15
@peterhoeg peterhoeg restored the f/crun branch February 24, 2020 16:40
@peterhoeg peterhoeg deleted the f/crun branch September 7, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant