Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] signal-desktop: fix notifications #79950

Merged
merged 1 commit into from Feb 12, 2020
Merged

[20.03] signal-desktop: fix notifications #79950

merged 1 commit into from Feb 12, 2020

Conversation

puckipedia
Copy link
Contributor

Motivation for this change

Backport of #79949

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@puckipedia
signal-desktop: fix notifications
a4cddd0 
(cherry picked from commit 0b3e5db)
@puckipedia puckipedia force-pushed the signal-desktop-notifications-20.03 branch from 3b3fce0 to a4cddd0 Compare February 12, 2020 22:43
@worldofpeace worldofpeace merged commit ae62101 into NixOS:release-20.03 Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos Awaiting requested review from primeos

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@puckipedia @worldofpeace