Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal-desktop: fix notifications #79949

Merged
merged 1 commit into from Feb 12, 2020
Merged

signal-desktop: fix notifications #79949

merged 1 commit into from Feb 12, 2020

Conversation

puckipedia
Copy link
Contributor

Motivation for this change

Because Electron, Signal Desktop doesn't actually directly link to libnotify, and dynamically loads it, which caused #77850 to break notifications. This adds libnotify to the runtime deps, bringing notifications back.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace merged commit 2d80e40 into NixOS:master Feb 12, 2020
@puckipedia puckipedia mentioned this pull request Feb 12, 2020
Merged
10 tasks
@primeos
Copy link
Member

primeos commented Feb 12, 2020

@puckipedia nice, thanks for the fix :)

primeos pushed a commit that referenced this pull request Feb 13, 2020
@puckipedia @primeos
signal-desktop: fix notifications
e02fb6e 
(cherry picked from commit 0b3e5db)
Reason: Backport of #79949 to fix the notifications.
pull bot pushed a commit to Frostman/nixpkgs that referenced this pull request Feb 16, 2020
@puckipedia @pull
signal-desktop: fix notifications
240384a 
(cherry picked from commit 0b3e5db)
Reason: Backport of NixOS#79949 to fix the notifications.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@primeos primeos Awaiting requested review from primeos

@ixmatus ixmatus Awaiting requested review from ixmatus

@equirosa equirosa Awaiting requested review from equirosa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@puckipedia @primeos @worldofpeace