packaging: Rename pkg to build-aux #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapcraft 3.3 introduced support for snap directories at build-aux/snap instead of only at root level. Take advantage of this by renaming pkg/ to build-aux/ which enables us to drop the hacky indirection of snap/build.sh, resulting in less complexity and a cleaner directory layout.
|
I quite dislike this change. I don't think that a single packaging mechanism should dictate the directory layout in a repository of a cross-platform application. |
|
It is also not even a good name; I use |
|
I like |
|
I think your original approach works perfectly fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapcraft 3.3 introduced support for snap directories
at build-aux/snap instead of only at root level.
Take advantage of this by renaming pkg/ to build-aux/
which enables us to drop the hacky indirection of snap/build.sh,
resulting in less complexity and a cleaner directory layout.
When I created the original snap packaging, I overlooked this feature which had been recently introduced. It's a neat opportunity to simplify stuff but it also moves the flatpak packaging. Not strictly necessary but still a very good idea, I feel.
Note:
build-auxfor packaging/building is very common within the GNOME ecosystem