ncurses: 6.1-20190112 -> 6.2 #80016
Merged
ncurses: 6.1-20190112 -> 6.2 #80016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzWill
reviewed
Feb 13, 2020
|
@GrahamcOfBorg build stdenv python3 |
mmilata
reviewed
Feb 17, 2020
| name = "ncurses-${version}" + lib.optionalString (abiVersion == "5") "-abi5-compat"; | ||
|
|
||
| # We cannot use fetchFromGitHub (which calls fetchzip) | ||
| # because we need to be able to use fetchurlBoot. | ||
| src = let | ||
| # Note the version needs to be adjusted. | ||
| rev = "acb4184f8f69fddd052a3daa8c8675f4bf8ce369"; | ||
| rev = "v${version}"; | ||
| in fetchurl { | ||
| url = "https://github.com/mirror/ncurses/archive/${rev}.tar.gz"; |
There was a problem hiding this comment.
What do you think about fetching this directly from https://ftp.gnu.org/gnu/ncurses/ncurses-6.2.tar.gz instead of third party mirror?
There was a problem hiding this comment.
At least development versions got removed often, see 43e867a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://invisible-island.net/ncurses/announce-6.2.html
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)