Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.imgaug: 0.3.0 -> 0.4.0 #79982

Merged
merged 1 commit into from Feb 13, 2020
Merged

python3Packages.imgaug: 0.3.0 -> 0.4.0 #79982

merged 1 commit into from Feb 13, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 13, 2020 •
edited

Motivation for this change

noticed the current package is broken from the pandas update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[8 built, 1 copied (0.9 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79982
2 package built:
python37Packages.imgaug python38Packages.imgaug

@jonringer
Copy link
Contributor Author

This fixes a broken build, merging

@jonringer jonringer merged commit 9ad3ee2 into NixOS:master Feb 13, 2020
@jonringer jonringer deleted the bump-imgaug branch February 13, 2020 06:27
@Rakesh4G
Copy link
Contributor

Rakesh4G commented Feb 14, 2020 •
edited

Hi @jonringer
By ignoring only one augmenter file test_imgcorruptlike.py, all other tests are passing without requiring anything extra.
pytest ./test --ignore=test/augmenters/test_imgcorruptlike.py
5031 passed, 4 skipped in 212.86s (0:03:32)
as compare to ignoring augmenter totally
1832 passed, 2 skipped in 35.22s
@CMCDragonkai
imgaug_tests.txt

@jonringer
Copy link
Contributor Author

if you would like to open a PR I would be happy to accept it. I was fixing a lot of packages yesterday:
#79990
#79989
#79986
#79985
#79982
#79958
#79869

@Rakesh4G
Copy link
Contributor

@jonringer No worries. I will open a PR. in between trying to see if i can get some solution for test/augmenters/test_imgcorruptlike.py

Thanks.

This was referenced Feb 14, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@CMCDragonkai CMCDragonkai Awaiting requested review from CMCDragonkai

@Rakesh4G Rakesh4G Awaiting requested review from Rakesh4G

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @Rakesh4G