Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.35.1 -> 0.36.0 #79983

Merged
merged 1 commit into from Feb 13, 2020
Merged

starship: 0.35.1 -> 0.36.0 #79983

merged 1 commit into from Feb 13, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Feb 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/sql2qq53vr19kgqxmamrwdkivsvhdksd-starship-0.35.1 38.5M
/nix/store/mrn2y1ai2ig3y6c12c2c4fs6qi7zd4c2-starship-0.36.0 38.6M

@ofborg ofborg bot requested review from davidtwco and Br1ght0ne February 13, 2020 06:21
@Frostman
Copy link
Member

nixpkgs-review passed ok (x86_64).

@davidtwco
Copy link
Member

Can also confirm with nixpkgs-review.

@marsam marsam merged commit df9671a into NixOS:master Feb 13, 2020
@bbigras bbigras deleted the starship branch February 13, 2020 14:08
@bbigras
Copy link
Contributor Author

bbigras commented Feb 13, 2020

thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @Frostman @davidtwco @marsam