Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromedriver: 78.0.3904.70 -> 80.0.3987.16 #79923

Merged
merged 1 commit into from Feb 12, 2020
Merged

chromedriver: 78.0.3904.70 -> 80.0.3987.16 #79923

merged 1 commit into from Feb 12, 2020

Conversation

cohei
Copy link
Contributor

@cohei cohei commented Feb 12, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cohei cohei marked this pull request as ready for review February 12, 2020 13:55
@marsam marsam merged commit 047c2bf into NixOS:master Feb 12, 2020
@marsam
Copy link
Contributor

marsam commented Feb 12, 2020

Thanks!

@cohei cohei deleted the update-chromedriver branch February 12, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cohei @marsam