Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim-remote: add now needed setuptools as input #80044

Merged
merged 1 commit into from Feb 13, 2020
Merged

neovim-remote: add now needed setuptools as input #80044

merged 1 commit into from Feb 13, 2020

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

Since a certain update, nvr crashed if it ran without the env NVIM_LISTEN_ADDRESS set. Upstream requires setuptools in it's setup.py, see https://github.com/mhinz/neovim-remote/blob/1ec7c6c76a66d8d381f54570d6fdd3079c190ba5/setup.py#L18 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[2 built, 2 copied (0.7 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80044
1 package built:
neovim-remote

@jonringer jonringer merged commit d416985 into NixOS:master Feb 13, 2020
@worldofpeace
Copy link
Contributor

worldofpeace commented Feb 13, 2020 •
edited

Needs backport to 20.03 (I think?).

@doronbehar doronbehar deleted the improve-neovim-remote branch March 2, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @worldofpeace @jonringer