Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c3d: unbreak via stdenv -> gcc8Stdenv #80046

Merged
merged 1 commit into from Feb 13, 2020
Merged

c3d: unbreak via stdenv -> gcc8Stdenv #80046

merged 1 commit into from Feb 13, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Feb 13, 2020 •
edited

Motivation for this change

c3d was unbroken by #72046 when that PR was created, but by the time it was merged this week it was broken again by GCC 9.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

This should also be backported to 20.03 if it's broken there as well (was branched Feb 10).

worldofpeace
worldofpeace suggested changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mark this as broken on aarch64-linux?
AFAICT, it's never built there https://hydra.nixos.org/job/nixpkgs/trunk/c3d.aarch64-linux/all.

meta = {
  ...
  broken = stdenv.isAarch64;
};

A comment with the error would be cool too.

/build/git-3453f61/itkextras/OneDimensionalInPlaceAccumulateFilter.txx:311:10: fatal error: xmmintrin.h: No such file or directory
 #include <xmmintrin.h>

^ it seems it can't find a header that's in gcc on that platform.

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 13, 2020
@bcdarwin
Copy link
Member Author

@worldofpeace -- done, thanks.

@worldofpeace worldofpeace merged commit 05f5786 into NixOS:master Feb 13, 2020
@bcdarwin bcdarwin deleted the c3d-downgrade-gcc branch February 13, 2020 22:49
@worldofpeace
Copy link
Contributor

worldofpeace commented Feb 13, 2020 •
edited

backports done in dee6990
95bf506. Thanks @bcdarwin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @worldofpeace