Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tentative from lazy load tests #21773

Merged
merged 1 commit into from Feb 13, 2020
Merged

Remove tentative from lazy load tests #21773

merged 1 commit into from Feb 13, 2020

Conversation

rwlbuis
Copy link
Contributor

@rwlbuis rwlbuis commented Feb 13, 2020

whatwg/html#3752 landed, so
remove comments and tentative extension.

@rwlbuis rwlbuis requested a review from annevk February 13, 2020 07:24
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-21773 February 13, 2020 07:26 Inactive
@annevk
Copy link
Member

annevk commented Feb 13, 2020 •
edited

It's a little weird for these to be a in top-level loading diretory. We we put them with the img element inside html/semantics/embedded-content/the-img-element/? Thanks for following up on this and sorry for not doing a better job with managing the tests when landing the change to HTML.

@domfarolino
Copy link
Member

Yes we discussed moving these at some point, but I guess we haven't done it yet. @rwlbuis do you want to go ahead and include the move in this PR?

And no worries @annevk

@rwlbuis
Copy link
Contributor Author

rwlbuis commented Feb 13, 2020

Yes we discussed moving these at some point, but I guess we haven't done it yet. @rwlbuis do you want to go ahead and include the move in this PR?

Yes, will do.

@rwlbuis
Remove tentative from lazy load tests
44b54aa 
whatwg/html#3752 landed, so
remove comments and tentative extension.
@rwlbuis
Copy link
Contributor Author

rwlbuis commented Feb 13, 2020

Yes we discussed moving these at some point, but I guess we haven't done it yet. @rwlbuis do you want to go ahead and include the move in this PR?

Done. Is it ok to remove META.yml?

@annevk
Copy link
Member

annevk commented Feb 13, 2020

You might want to keep it if you want to get review requests for changes in that directory.

@rwlbuis
Copy link
Contributor Author

rwlbuis commented Feb 13, 2020

You might want to keep it if you want to get review requests for changes in that directory.

Don't really want review requests personally :) Anyway I think it will become clear who could be reviewers for lazy image loading. Or we could add it later if there is a lot of confusion.

@rwlbuis rwlbuis merged commit 283eaa7 into master Feb 13, 2020
@rwlbuis rwlbuis deleted the tentative_removal branch February 13, 2020 09:49
pull bot pushed a commit to FreddyZeng/chromium that referenced this pull request Feb 21, 2020
@rwlbuis
Remove wpt/loading/lazyload directory
2e305c7 
The tests moved to html/semantics/embedded-content/the-img-element:
web-platform-tests/wpt#21773
So the directory and remaining expected results can be removed.

Change-Id: Ib073dd3ca8cd6c6ec27e5c542cd38546fb87e4b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066764
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#743534}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domfarolino domfarolino domfarolino approved these changes

@annevk annevk Awaiting requested review from annevk

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zcorpan zcorpan Awaiting requested review from zcorpan

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@domfarolino domfarolino

Labels
html loading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rwlbuis @annevk @domfarolino @wpt-pr-bot