Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Gecko Bug 1614329] Fix the handling of the type attribute of HTMLStyleElement" #21767

Closed
wants to merge 1 commit into from

Conversation

Hexcles
Copy link
Member

@Hexcles Hexcles commented Feb 12, 2020

Reverts #21736

@Hexcles
Copy link
Member Author

Hexcles commented Feb 12, 2020

I'm not sure -- is this redundant with https://github.com/web-platform-tests/wpt/blob/master/html/semantics/document-metadata/the-style-element/style_type.html ? @ehsan

If this was intentional, then we have yet another example of #7570 and we might just have to rename them.

@Hexcles Hexcles assigned ehsan and jgraham and unassigned jgraham Feb 12, 2020
@Hexcles
Copy link
Member Author

Hexcles commented Feb 12, 2020

FYI @KyleJu this is blocking wpt-import

@annevk
Copy link
Member

annevk commented Feb 13, 2020

FWIW, this looks very much intentional. Ensuring there's no subtle differences between HTML and XML code paths.

Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think reverting this is the wrong thing to do. If there are Blink-specific rules around file naming they should be encoded in the lint (and existing instances can be fixed).

@Hexcles
Copy link
Member Author

Hexcles commented Feb 13, 2020

Sorry if I wasn't clear: I wasn't going to just land this, but was genuinely unsure. And thanks for the answer @annevk ; @jgraham yeah I'll send another PR to rename them.

@Hexcles Hexcles closed this Feb 13, 2020
@Hexcles Hexcles deleted the revert-21736-gecko/1614329 branch February 13, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants