[Gecko Bug 1542784] Implement lazy loading for images. #21768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though with this initial implementation, we do create an IntersectionObserver only for the root document in each processes, once we found issues on this model, we can create an IntersectionObserver in each _document_. Depends on D61437 Differential Revision: https://phabricator.services.mozilla.com/D61438 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 gecko-commit: e27886fc6a2a2b2915bebfbc6f22e494cd11404c gecko-integration-branch: autoland gecko-reviewers: emilio, hsivonen
There are two variation of the tests. 1) The image element gets visible by scrolling the iframe's scrollport. 2) The image element gets visible by scrolling the parent scroll container of the iframe Depends on D61438 Differential Revision: https://phabricator.services.mozilla.com/D61439 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 gecko-commit: 738e2a3729cf0cfcac567a70aedfdc0ed2b652a9 gecko-integration-branch: autoland gecko-reviewers: emilio
…e iframe. Depends on D61439 Differential Revision: https://phabricator.services.mozilla.com/D61440 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 gecko-commit: aaf6810da7b91208c554149aee293feba8ac7d20 gecko-integration-branch: autoland gecko-reviewers: emilio
…document. Depends on D61440 Differential Revision: https://phabricator.services.mozilla.com/D61441 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 gecko-commit: f2f84d35d5cce212443922b34e07f2c7660062ed gecko-integration-branch: autoland gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though with this initial implementation, we do create an IntersectionObserver
only for the root document in each processes, once we found issues on this
model, we can create an IntersectionObserver in each document.
Depends on D61437
Differential Revision: https://phabricator.services.mozilla.com/D61438
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1542784
gecko-commit: e27886fc6a2a2b2915bebfbc6f22e494cd11404c
gecko-integration-branch: autoland
gecko-reviewers: emilio, hsivonen