Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polar-bookshelf: 1.13.10 -> 1.90.18 #79947

Closed
wants to merge 1 commit into from
Closed

polar-bookshelf: 1.13.10 -> 1.90.18 #79947

wants to merge 1 commit into from

Conversation

claudiiii
Copy link
Contributor

Motivation for this change

Version in nixpkgs was outdated and I wanted a newer version.
Had to change the executable target of the symlink otherwise it would complain about not finding polar-bokshelf.bin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

evenbrenden
evenbrenden approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@evenbrenden evenbrenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64 (Ubuntu 18.04)
  • package build on x86_64 (NixOS)
  • executables tested on x86_64 (Ubuntu 18.04)
  • executables tested on x86_64 (NixOS)
  • all depending packages build (Ubuntu 18.04)
  • all depending packages build (NixOS)

@alyssais
Copy link
Member

Hi! Sorry this has been left for so long. The email address used for the commit doesn’t seem to be registered to your GitHub account — do you want to check it used the right one?

Also, the commit message should follow the format in CONTRIBUTING.md (the title of the PR would be perfect as a commit message). I can fix this up for you if you prefer.

@claudiiii
Copy link
Contributor Author

I don't use polar anymore and there where problems with opening external links, so I will close this.

@claudiiii claudiiii closed this Aug 20, 2020
@claudiiii claudiiii deleted the update-polar branch February 2, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenbrenden evenbrenden evenbrenden approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@claudiiii @alyssais @evenbrenden @Janik-Haag