Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stretchly: 0.21.0 -> 0.21.1, use system electron, simplify #80035

Merged
merged 1 commit into from Mar 25, 2020
Merged

stretchly: 0.21.0 -> 0.21.1, use system electron, simplify #80035

merged 1 commit into from Mar 25, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 13, 2020

Motivation for this change

Cleanup and prefer our electron.
Works well here, but let's check with maintainer for approval ;).

Neat app, noticed after electron refactoring PR and am giving a whirl
starting today! :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cdepillabout February 13, 2020 18:18
cdepillabout
cdepillabout approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification! LGTM.

I actually don't use stretchly that much anymore, so please feel free to add yourself as a maintainer.

@aanderse
Copy link
Member

Merging based on maintainer approval.

@aanderse aanderse merged commit a15e0da into NixOS:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @aanderse @cdepillabout