Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that WebAssembly objects are validated. #21778

Merged
merged 1 commit into from Feb 17, 2020
Merged

Verify that WebAssembly objects are validated. #21778

merged 1 commit into from Feb 17, 2020

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Feb 13, 2020

@Ms2ger Ms2ger requested a review from ioannad February 13, 2020 13:34
ioannad
ioannad approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@ioannad ioannad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds three validation tests: for a wrong global type, for a too large memory, and for a too large table.

@ioannad ioannad merged commit 49c836f into master Feb 17, 2020
@ioannad ioannad deleted the wasm-bad-imports branch February 17, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioannad ioannad ioannad approved these changes

Assignees

@titzer titzer

Labels
wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ms2ger @ioannad @titzer @wpt-pr-bot