Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] zfs: 0.8.2 -> 0.8.3 #79938

Closed
wants to merge 3 commits into from
Closed

[19.09] zfs: 0.8.2 -> 0.8.3 #79938

wants to merge 3 commits into from

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 12, 2020 •
edited

Motivation for this change

Zfs 0.8.3 is included into release-20.03 and it contains many important fixes and improvements https://github.com/zfsonlinux/zfs/releases/tag/zfs-0.8.3 such as - Linux 5.0 compat: SIMD compatibility openzfs/zfs#8965

Additionally, synced two more minor patches to get release-19.09 up to date with master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

Mic92 and others added 3 commits February 12, 2020 09:27
@Mic92 @Frostman
zfsUnstable: drop build patches
8527db6 
(cherry picked from commit 539e66c)
@woffs @Frostman
zfs: fix PATH for zpool.d scripts
1974113 
(cherry picked from commit 17f76a9)
@Frostman
zfs: 0.8.2 -> 0.8.3
99d473a 
(cherry picked from commit 88de34b)
@Frostman Frostman changed the title [19.09] zfs: 0.8.2 -> 0.8.3 (WIP) [19.09] zfs: 0.8.2 -> 0.8.3 Feb 12, 2020
@Frostman
Copy link
Member Author

I've tested it locally with nixpkgs-review and it succeded. The nixosTests.installer.zfsroot passes as well.

@Frostman
Copy link
Member Author

@GrahamcOfBorg build nixosTests.installer.zfsroot

@Frostman Frostman changed the title (WIP) [19.09] zfs: 0.8.2 -> 0.8.3 [19.09] zfs: 0.8.2 -> 0.8.3 Feb 12, 2020
@Mic92
Copy link
Member

Mic92 commented Feb 13, 2020

Actually we should not been affected by the SIMD patch because I simply patched the kernel to expose the fpu functions needed by ZFS. I might have not backported those to stable though.

@Mic92
Copy link
Member

Mic92 commented Feb 13, 2020

However support for new kernels is a good thing to have nevertheless.

@Mic92
Copy link
Member

Mic92 commented Feb 13, 2020

I will merge this together with #80008

@Mic92 Mic92 closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@markuskowa markuskowa Awaiting requested review from markuskowa

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @Mic92 @woffs