[Gecko Bug 1614674] Poll for load in CSP frame-ancestors tests #21757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 12, 2020
These tests are all timing out in Firefox because we don't send either a load or an error event for CSP-blocked loads. To work around this, poll the iframe for the load, assuming it's complete when we see a non-about:blank document with readyState complete (or an exception from trying to access a cross-origin resource). Differential Revision: https://phabricator.services.mozilla.com/D62447 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1614674 gecko-commit: 25bfc69bd9cc90510c530600d3141e4cf05821cb gecko-integration-branch: autoland gecko-reviewers: bzbarsky
moz-wptsync-bot
force-pushed
the
gecko/1614674
branch
from
4ffd7bb
to
a4009a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are all timing out in Firefox because we don't send either
a load or an error event for CSP-blocked loads. To work around this,
poll the iframe for the load, assuming it's complete when we see a
non-about:blank document with readyState complete (or an exception
from trying to access a cross-origin resource).
Differential Revision: https://phabricator.services.mozilla.com/D62447
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1614674
gecko-commit: a2bf92004940994b68132da4d82c3965af991535
gecko-integration-branch: autoland
gecko-reviewers: bzbarsky