Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profanity: 0.7.1 -> 0.8.1 #80023

Merged
merged 1 commit into from Feb 13, 2020
Merged

profanity: 0.7.1 -> 0.8.1 #80023

merged 1 commit into from Feb 13, 2020

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Feb 13, 2020

Changelog available at:
https://github.com/profanity-im/profanity/releases/tag/0.8.1

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@devhell
Copy link
Contributor Author

devhell commented Feb 13, 2020

@GrahamcOfBorg build

jonringer
jonringer approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
shows usage

[3 built, 23 copied (18.4 MiB), 3.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80023
1 package built:
profanity

@jonringer jonringer merged commit c87ec93 into NixOS:master Feb 13, 2020
@devhell devhell deleted the profanity-0.8.1 branch February 13, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devhell @jonringer