r128gain: 0.9.3 -> 1.0.1 #79924
Merged
r128gain: 0.9.3 -> 1.0.1 #79924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Feb 12, 2020
AluisioASG
force-pushed
the
aasg/r128gain
branch
from
8862fc9
to
eefe881
Compare
|
I still need to note in the commit message that I've switched to fetching r128gain from GitHub so I can run the tests locally with the sandbox disabled. |
AluisioASG
force-pushed
the
aasg/r128gain
branch
2 times, most recently
from
1a70531
to
6035289
Compare
jonringer
reviewed
Feb 13, 2020
There was a problem hiding this comment.
seems to be a regression in the beets package
[47 built (2 failed), 176 copied (531.6 MiB), 153.6 MiB DL]
error: build of '/nix/store/nlqiwpvh7yc6xcpjljcvy2r9h38wj75z-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79924
2 package failed to build:
beets mopidy-gmusic
30 package built:
cozy dir2opus gtkpod libgpod whipper mpdris2 nicotine-plus pantheon.elementary-music picard puddletag python27Packages.ffmpeg-python python27Packages.gmusicapi python27Packages.mutagen python27Packages.podcats python37Packages.ffmpeg-python python37Packages.gmusicapi python37Packages.mutagen python37Packages.podcats python38Packages.ffmpeg-python python38Packages.gmusicapi python38Packages.mutagen python38Packages.podcats quodlibet quodlibet-full quodlibet-without-gst-plugins quodlibet-xine quodlibet-xine-full r128gain rofi-mpd split2flac
master:
[09:26:06] jon@jon-desktop /home/jon/projects/nixpkgs (master)
$ nix-build -A beets
/nix/store/dimbvay1js4amf0fhsf2n25g94ywwmlz-beets-1.4.9
|
It's beetbox/mediafile#24. I'm backporting beetbox/mediafile@b3343c4 to beets so it works with the new mutagen. |
Not updating to 1.44.0 due to it dropping Python 2 support.
Switched the source to GitHub so that test files are available for local, unsandboxed testing.
AluisioASG
force-pushed
the
aasg/r128gain
branch
from
6035289
to
98e2817
Compare
|
Fixed and rebased. cc @aszlig @domenkozar @pjones for Beets patch |
jonringer
reviewed
Feb 15, 2020
There was a problem hiding this comment.
this also seems to cause a regression in cozy due to the mutagen bump:
before
# opens gui
after
$ ./results/cozy/bin/cozy
** (gst-plugin-scanner:12503): CRITICAL **: 18:09:50.844: Couldn't g_module_open libpython. Reason: /nix/store/g20g00saxyssz0ka1xcmcm31bfq6iq31-python3-3.7.6/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory
** (gst-plugin-scanner:12503): CRITICAL **: 18:09:50.849: Couldn't g_module_open libpython. Reason: /nix/store/g20g00saxyssz0ka1xcmcm31bfq6iq31-python3-3.7.6/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory
** (gst-plugin-scanner:12503): CRITICAL **: 18:09:50.851: Couldn't g_module_open libpython. Reason: /nix/store/g20g00saxyssz0ka1xcmcm31bfq6iq31-python3-3.7.6/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory
** (gst-plugin-scanner:12503): CRITICAL **: 18:09:50.852: Couldn't g_module_open libpython. Reason: /nix/store/g20g00saxyssz0ka1xcmcm31bfq6iq31-python3-3.7.6/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory
['/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/.com.github.geigi.cozy-wrapped']
/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/..com.github.geigi.cozy-wrapped-wrapped:60: PyGIDeprecationWarning: Since version 3.11, calling threads_init is no longer needed. See: https://wiki.gnome.org/PyGObject/Threading
GObject.threads_init()
/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/..com.github.geigi.cozy-wrapped-wrapped:71: DeprecationWarning: dist() and linux_distribution() functions are deprecated in Python 3.5
log.info(platform.dist())
18:09:52 [MainThread ] [main ] [INFO ] ('', '', '')
18:09:52 [MainThread ] [main ] [INFO ] Starting up cozy 0.6.7
Traceback (most recent call last):
File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/db.py", line 390, in update_db
next(c for c in db.get_columns("settings") if c.name == "version")
StopIteration
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/..com.github.geigi.cozy-wrapped-wrapped", line 74, in do_startup
init_db()
File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/db.py", line 129, in init_db
update_db()
File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/db.py", line 397, in update_db
update_db_1()
File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/db.py", line 299, in update_db_1
migrator.add_column('track', 'crc32', crc32),
File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 823, in migrate
operation.run()
File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 160, in run
self._handle_result(method(*self.args, **kwargs))
File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 154, in _handle_result
self._handle_result(item)
File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 151, in _handle_result
result.run()
File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 160, in run
self._handle_result(method(*self.args, **kwargs))
File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 151, in _handle_result
result.run()
File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 160, in run
self._handle_result(method(*self.args, **kwargs))
File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 168, in inner
return fn(self, *args, **kwargs)
File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 644, in _update_column
(column_to_update, table))
ValueError: Column "version" does not exist on "settings"
(.com.github.geigi.cozy-wrapped:12480): GLib-GIO-CRITICAL **: 18:09:52.525: GApplication subclass '__main__+Application' failed to chain up on ::startup (from start of override function)
18:09:52 [MainThread ] [ui ] [INFO ] Initialize main window
Traceback (most recent call last):
File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/..com.github.geigi.cozy-wrapped-wrapped", line 79, in do_activate
self.ui.activate()
File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/ui.py", line 59, in activate
self.__init_window()
File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/ui.py", line 128, in __init_window
self.window = self.window_builder.get_object("app_window")
AttributeError: 'CozyUI' object has no attribute 'window_builder'
(.com.github.geigi.cozy-wrapped:12480): GLib-GIO-CRITICAL **: 18:09:52.527: GApplication subclass '__main__+Application' failed to chain up on ::shutdown (from end of override function)
|
Hmm, I'm unable to replicate that. This is what I get when I run it on KDE for the first time and import a few files (with duplicated lines removed): I can close it, reopen, and play a file with no issues. I also tried erasing all data, running the pre-upgrade version ( |
|
I also don't have a DE, so that may be contributing |
|
hmm, cozy works fine on a different computer. No idea. |
jonringer
approved these changes
Feb 15, 2020
There was a problem hiding this comment.
LGTM
commits LGTM
[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79924
31 package built:
beets cozy dir2opus gtkpod libgpod mpdris2 nicotine-plus pantheon.elementary-music picard puddletag python27Packages.ffmpeg-python python27Packages.gmusicapi python27Packages.mutagen python27Packages.podcats python37Packages.ffmpeg-python python37Packages.gmusicapi python37Packages.mutagen python37Packages.podcats python38Packages.ffmpeg-python python38Packages.gmusicapi python38Packages.mutagen python38Packages.podcats quodlibet quodlibet-full quodlibet-without-gst-plugins quodlibet-xine quodlibet-xine-full r128gain rofi-mpd split2flac whipper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @FRidh for mutagen update