Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/redis: add requirePassFile option #80032

Merged
merged 1 commit into from Feb 17, 2020
Merged

nixos/redis: add requirePassFile option #80032

merged 1 commit into from Feb 17, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 13, 2020

Avoids having the password in the nix store.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Avoids having the password in the nix store.
@Mic92
Copy link
Member Author

Mic92 commented Feb 13, 2020

@GrahamcOfBorg test redis

preStart = ''
install -m 600 ${redisConfig} /run/redis/redis.conf
'' + optionalString (cfg.requirePassFile != null) ''
password=$(cat ${escapeShellArg cfg.requirePassFile})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is escapeShellArg used instead of quoting the filename? I think this would be more readable: $(cat "${cfg.requirePassFile}")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. $(cat "${cfg.requirePassFile}") could in theory be a problem if requirePassFile contains a ". Should ignore this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't think of that. Never mind then!

@Mic92 Mic92 merged commit 7448211 into NixOS:master Feb 17, 2020
@Mic92 Mic92 deleted the redis branch February 17, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants