Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave 1.1.23 to 1.3.113 #79974

Merged
merged 2 commits into from Feb 16, 2020
Merged

Brave 1.1.23 to 1.3.113 #79974

merged 2 commits into from Feb 16, 2020

Conversation

JeffLabonte
Copy link
Contributor

Motivation for this change

I needed the latest version of Brave, I made the change of version and wanted to share with the others.

Things done

Change the version to the latest stable and update the checksum. Add my name to the lists of maintainers

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and executes.
It seems there was a newer release already though https://github.com/brave/brave-browser/releases/tag/v1.3.115.

@worldofpeace
Copy link
Contributor

worldofpeace commented Feb 13, 2020 •
edited

I will try to backport this to 20.03 as well.

@JeffLabonte
Copy link
Contributor Author

@worldofpeace, thank you for your review! Wow! They update quite often these days!

worldofpeace
worldofpeace approved these changes Feb 16, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also rewrote your git history for you.

@worldofpeace worldofpeace merged commit 2b8e192 into NixOS:master Feb 16, 2020
@uskudnik
Copy link
Contributor

Much obliged @JeffLabonte, one of the previous versions had a broken full screen mode on for i3 window manager - this one fixes that. Thank you! ❤️

@JeffLabonte JeffLabonte mentioned this pull request Feb 26, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@zowoq zowoq Awaiting requested review from zowoq

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeffLabonte @worldofpeace @uskudnik