Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ell,iwd: 0.28, 1.5, minor touchups, drop tmpfiles snippet #79961

Merged
merged 5 commits into from Feb 13, 2020
Merged

ell,iwd: 0.28, 1.5, minor touchups, drop tmpfiles snippet #79961

merged 5 commits into from Feb 13, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 13, 2020 •
edited

Motivation for this change

See commits, but:

  • ell: 0.27 -> 0.28
  • iwd: 1.4 -> 1.5
  • iwd: drop systemd dep, not needed when specifying config flags too
  • iwd: tests, openssl check dep

NixOS module:

  • drop tmpfiles snippet, this shouldn't be needed due to StateDirectory directives in service fails AFAIK?
  • Add myself to maintainers list too :)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
ell: 0.27 -> 0.28
3b99307
@dtzWill
iwd: 1.4 -> 1.5
5f51a18
@dtzWill
iwd: drop systemd dep, not needed when specifying config flags too
54f35e4 
Only used to guess if systemd-y bits should be installed,
which we manually specify already.  So drop unneeded dep.
@dtzWill
iwd: tests, openssl check dep
f9b5108
@ofborg ofborg bot requested review from Mic92 and fpletz February 13, 2020 01:25
@dtzWill
iwd: drop tmpfiles snippet, services use StateDirectory already
ac8a925 
Originally added in [1], and iwd added StateDirectory to its services
in [2] -- 4 days later.

("StateDirectory wasn't used when tmpfile snippet was added to NixOS")
(nevermind git -> release delay)

[1] 6e54e92
[2] upstream iwd git rev: 71ae0bee9c6320dae0083ed8c1700bc8fff1defb
@dtzWill dtzWill changed the title ell,iwd: 0.28, 1.5, minor touchups ell,iwd: 0.28, 1.5, minor touchups, drop tmpfiles snippet Feb 13, 2020
@dtzWill
Copy link
Member Author

dtzWill commented Feb 13, 2020

The tmpfiles change was inspired by similar recently made elsewhere-- speak up if there's any push-back there :).

@Mic92 Mic92 merged commit b300ccd into NixOS:master Feb 13, 2020
@Mic92
Copy link
Member

Mic92 commented Feb 13, 2020

Thanks!

@Mic92
Copy link
Member

Mic92 commented Feb 13, 2020

The tmpfiles change was inspired by similar recently made elsewhere-- speak up if there's any push-back there :).

Yes. This should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @Mic92