Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.bump2version: init at 1.0.0 #80053

Merged
merged 1 commit into from Feb 15, 2020
Merged

gitAndTools.bump2version: init at 1.0.0 #80053

merged 1 commit into from Feb 15, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Feb 13, 2020 •
edited by jonringer

Motivation for this change

I need it at my work to bump my versions in my software

Things done

Create a new package to install in python 3 bump2version from Pypi

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Feb 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clean up git history, you have 3 irrelevant commits

@JeffLabonte JeffLabonte force-pushed the init_pythonPackage_bump2version branch from f086445 to 94d7f05 Compare February 13, 2020 20:28
@JeffLabonte
Copy link
Contributor Author

I was just doing the cleanup when you left the comment! That was fast!

cole-h
cole-h reviewed Feb 13, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nitpick, but it would be nice if you could modify your commit message to match the specification found in CONTRIBUTING.md.

E.g. bump2version: init at 1.0.0 See below.

@jonringer
Copy link
Contributor

It should be the installable path (the full path to the package). For python packages, it should be:

pythonPackages.bump2version: init at 1.0.0

using interpreter specific version is also fine, if needed to differentiate

python3Packages.bump2version: init at 1.0.0

@JeffLabonte JeffLabonte force-pushed the init_pythonPackage_bump2version branch from d721e7e to fe95b2d Compare February 14, 2020 01:26
@JeffLabonte
Copy link
Contributor Author

I preferred to use the latter since this packages doesn't have a support available for python 2.7 anymore.

@jonringer jonringer changed the title Init python package bump2version python3Packages.bump2version: init at 1.0.0 Feb 14, 2020
jonringer
jonringer reviewed Feb 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stepping back, I think this package is mean to be used through it' cli. If it's mean to be a command-line utility, it doesn't really need to go to into python-modules.

It could just be included in gitAndTools, and do something like:

  bump2version = python3.pkgs.callPackage ./bump2version { };

pkgs/development/python-modules/bump2version/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/bump2version/default.nix Outdated Show resolved Hide resolved
@JeffLabonte JeffLabonte force-pushed the init_pythonPackage_bump2version branch 3 times, most recently from 89af557 to 513906f Compare February 14, 2020 05:30
@JeffLabonte
Copy link
Contributor Author

Make sense to move the package to gitAndTools, i made the change!

@JeffLabonte
Copy link
Contributor Author

What would be the path in my commit message then ? @jonringer

@ofborg ofborg bot removed the 6.topic: python label Feb 14, 2020
jonringer
jonringer reviewed Feb 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message would be:

gitAndTools.bump2version: init at 1.0.0

pkgs/applications/version-management/git-and-tools/bump2version/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/git-and-tools/bump2version/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/git-and-tools/bump2version/default.nix Outdated Show resolved Hide resolved
@JeffLabonte JeffLabonte force-pushed the init_pythonPackage_bump2version branch from 513906f to 8523200 Compare February 15, 2020 00:33
@JeffLabonte
Copy link
Contributor Author

Thank @jonringer ! You allowed me to learn a few more things!

jonringer
jonringer approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
has tests 👍

[3 built, 1 copied (0.7 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80053
1 package built:
gitAndTools.bump2version

@jonringer
Copy link
Contributor

@GrahamcOfBorg build gitAndTools.bump2version

@jonringer jonringer changed the title python3Packages.bump2version: init at 1.0.0 gitAndTools.bump2version: init at 1.0.0 Feb 15, 2020
@jonringer jonringer merged commit ebf01d5 into NixOS:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeffLabonte @jonringer @cole-h