Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[badging] rename idlharness.any.js to idlharness.https.any.js #21777

Merged
merged 1 commit into from Feb 13, 2020

Conversation

foolip
Copy link
Member

@foolip foolip commented Feb 13, 2020

[SecureContext] is used so the API is only available over HTTPS.

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

`[SecureContext]` is used so the API is only available over HTTPS.
Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun, so the API just doesn't exist in http? Well, that's something to keep an eye out for in the future.

I wonder if we could fix the idl harness to notice SecureContext and error if location is not https? Maybe has implications I'm not aware of.

@stephenmcgruer stephenmcgruer merged commit 19596c7 into master Feb 13, 2020
@stephenmcgruer stephenmcgruer deleted the foolip/badging-https branch February 13, 2020 12:31
@foolip
Copy link
Member Author

foolip commented Feb 13, 2020

The ideal thing would be to run tests in both secure and non-secure contexts and assert the absence of the APIs when they should be absent. But that's very much a nice-to-have, as it is the rule of thumb is that if anything under test is [SecureContext] then use HTTPS, and otherwise HTTP. I'm sure there are exceptions though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants