Revert "[Layout] SetNeedsLayout when an flex-item image loads" #21784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8495f49a06325e133bdf7852aaf83f52700209a1. Reason for revert: Suspected of causing failure in external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-003v.html on multiple builders, https://crbug.com/1052029 Original change's description: > [Layout] SetNeedsLayout when an flex-item image loads > > Flex layout incorporates an image's intrinsic size even when it has a > specified height and width. > > Bug: 1042329 > Change-Id: I206ba12a07103b4b90c364fb19b70b8ba2784d7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050821 > Commit-Queue: David Grogan <dgrogan@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#741091} TBR=dgrogan@chromium.org,fs@opera.com Change-Id: I7dbc00b05f9a14b955f5ac9cd89e3aeda1dbba0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042329 Bug: 1052029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054296 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741119}
wpt-pr-bot
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8495f49a06325e133bdf7852aaf83f52700209a1.
Reason for revert: Suspected of causing failure in external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-003v.html on multiple builders, https://crbug.com/1052029
Original change's description:
TBR=dgrogan@chromium.org,fs@opera.com
Change-Id: I7dbc00b05f9a14b955f5ac9cd89e3aeda1dbba0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1042329
Bug: 1052029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054296
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741119}