Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godot: 3.1.2 -> 3.2 #79957

Merged
merged 1 commit into from Mar 6, 2020
Merged

godot: 3.1.2 -> 3.2 #79957

merged 1 commit into from Mar 6, 2020

Conversation

mirrexagon
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I successfully loaded and ran a small game project on NixOS.

@mirrexagon
Copy link
Contributor Author

cc @Twey

@juliendehos juliendehos mentioned this pull request Feb 18, 2020
Closed
10 tasks
@invpt
Copy link

invpt commented Feb 18, 2020

Tested on my machine using sandboxing, works perfectly.

@aanderse
Copy link
Member

aanderse commented Mar 2, 2020

Does anyone have the context to speak to the changes in pkgs/development/tools/godot/dont_clobber_environment.patch so someone can hit 'merge' and feel good about it?

@Moredread
Copy link
Contributor

@aanderse not directly, but it seems that only the patch context changed, the actual patched code remains the same. So it should behave like before, I think.

Moredread
Moredread approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@Moredread Moredread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, tested execution with sandbox build and the FPS demo project

@mirrexagon
Copy link
Contributor Author

@aanderse @Moredread Yeah, I just edited the patch context to get it to apply again. I believe it functions the same as it used to.

@aanderse
Copy link
Member

aanderse commented Mar 6, 2020

Ok thanks everyone. Merging based on feedback 👍

@aanderse aanderse merged commit 7218f3a into NixOS:master Mar 6, 2020
@mirrexagon mirrexagon deleted the godot-3.2 branch March 7, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moredread Moredread Moredread approved these changes

@tilpner tilpner Awaiting requested review from tilpner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mirrexagon @invpt @aanderse @Moredread