Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libksi: Bump openssl dependency for rsyslogd #81851

Merged
merged 1 commit into from Mar 13, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Mar 5, 2020

Motivation for this change

rsyslogd is currently not building because of this, causing the -small jobset to fail its eval on both unstable and 20.03 since #80746.
I'm not sure if rsyslog will be working after this bump, as I don't have an rsyslog setup (is anyone even using this since journald remoting exist?).
The rsyslogd binary launches correctly, but it it didn't do any SSL stuff so I was unable to test that.

Also, I have no idea how big the impact of this PR is…

cc @NixOS/nixos-release-managers if it works, it needs a backport to 20.03 to fix the eval.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
Copy link
Member Author

dasJ commented Mar 5, 2020

@GrahamcOfBorg build rsyslog
@GrahamcOfBorg test rsyslogd

@alyssais alyssais merged commit ecc0110 into NixOS:master Mar 13, 2020
@dasJ dasJ deleted the bump-libksi branch March 13, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants