Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protonvpn ng update 2.2.0 to 2.2.2 #81735

Merged
merged 1 commit into from Mar 25, 2020
Merged

Protonvpn ng update 2.2.0 to 2.2.2 #81735

merged 1 commit into from Mar 25, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Mar 4, 2020 •
edited

Motivation for this change

I use this VPN and I was getting messages telling me to upgrade. I wanted to give this to the community

Things done

Update version from 2.2.0 to 2.2.2, update the sha256 sum, and add myself as a maintainer of this package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jtcoolen March 4, 2020 16:45
@jtcoolen
Copy link
Member

jtcoolen commented Mar 4, 2020

Built and tested locally, it works fine. Could you please merge your two commits into one?

@JeffLabonte
Copy link
Contributor Author

JeffLabonte commented Mar 5, 2020 •
edited

Built and tested locally, it works fine. Could you please merge your two commits into one?

@jtcoolen Is there a reason you would prefer to have it into one commit? is it for the backport? I can take care of that.

@jtcoolen
Copy link
Member

jtcoolen commented Mar 5, 2020

The second change is really part of the first one, so one commit suffices.

@JeffLabonte JeffLabonte force-pushed the protonvpn-ng_update_2.2.0_to_2.2.2 branch from 57135ab to eb96574 Compare March 5, 2020 15:20
@JeffLabonte
Copy link
Contributor Author

@jtcoolen done!

jtcoolen
jtcoolen approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@jtcoolen jtcoolen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for contributing! Could you merge this change @worldofpeace?

@JeffLabonte
Copy link
Contributor Author

@jtcoolen I will take care of backporting this to 19.09 and 20.03 later today! Thank you for your contributions as well my dear fellow Nix User :)

This was referenced Mar 6, 2020
Closed
Merged
@JeffLabonte JeffLabonte mentioned this pull request Mar 19, 2020
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/pr-approved-needs-merging-protonvpn-cli-ng/6406/1

@JeffLabonte
Copy link
Contributor Author

I have found that we were missing one dependency with this package: iptables .

On a new installation, I wasn't able to connect to one of the VPNs, until I installed iptables. Making the changes @bhipple!

@JeffLabonte JeffLabonte force-pushed the protonvpn-ng_update_2.2.0_to_2.2.2 branch from eb96574 to 5cb4488 Compare March 25, 2020 00:33
@bhipple
Copy link
Contributor

bhipple commented Mar 25, 2020

LGTM, can you squash the two commits, then I'll merge?

@JeffLabonte JeffLabonte force-pushed the protonvpn-ng_update_2.2.0_to_2.2.2 branch from 5cb4488 to 9fe4a63 Compare March 25, 2020 00:44
@ofborg ofborg bot requested a review from jtcoolen March 25, 2020 00:44
@JeffLabonte
Copy link
Contributor Author

@bhipple Done! I will backport the commit to the 20.03 and 19.09! :D

Thank you

@bhipple
Copy link
Contributor

bhipple commented Mar 25, 2020 

[2 built, 6 copied (2.4 MiB), 0.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81735
1 package built:
protonvpn-cli-ng

@bhipple bhipple merged commit ba1bf84 into NixOS:master Mar 25, 2020
This was referenced Mar 25, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@jtcoolen jtcoolen Awaiting requested review from jtcoolen

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeffLabonte @jtcoolen @nixos-discourse @bhipple