Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bisonpp: init at 1.21-45 #81736

Closed
wants to merge 1 commit into from
Closed

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Mar 4, 2020

Adding bisonpp library (no tests included)

Motivation for this change

Needed for building https://github.com/omnisci/omniscidb

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Adding bisonpp library (no tests included)
@costrouc
Copy link
Member Author

costrouc commented Mar 4, 2020

@GrahamcOfBorg build bisonpp

Copy link
Contributor

@Valodim Valodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, works as expected, other than the uri comment and merge conflict.


meta = with stdenv.lib; {
description = "The original bison++ project, brought up to date with modern compilers";
homepage = https://github.com/jarro2783/bisonpp;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://github.com/jarro2783/bisonpp;
homepage = "https://github.com/jarro2783/bisonpp";

@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@onny
Copy link
Contributor

onny commented Sep 7, 2022

Please rebase

@onny onny marked this pull request as draft September 7, 2022 06:37
@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants