Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "defaultGemConfig: remove asciidoctor-diagram JARs" #81737

Merged
merged 1 commit into from Mar 4, 2020

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Mar 4, 2020

This reverts commit 1ac11cc.

asciidoctor-diagram starts Java processes, so the JARs are necessary
on all platforms.

See #77149 (comment).

@nomeata please test

This reverts commit 1ac11cc.

asciidoctor-diagram starts Java processes, so the JARs are necessary
on all platforms.

See NixOS#77149 (comment).
@alyssais alyssais requested review from zimbatm and nomeata March 4, 2020 16:44
@alyssais alyssais added 9.needs: port to stable A PR needs a backport to the stable release. and removed 0 - Backlog labels Mar 4, 2020
@ofborg ofborg bot added the 6.topic: ruby label Mar 4, 2020
Copy link
Contributor

@nomeata nomeata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, brief local testing successful.

@zimbatm zimbatm merged commit 89a0945 into NixOS:master Mar 4, 2020
zimbatm added a commit that referenced this pull request Mar 4, 2020
This reverts commit 1ac11cc.

asciidoctor-diagram starts Java processes, so the JARs are necessary
on all platforms.

See #77149 (comment).

(cherry picked from commit 89a0945)
@zimbatm
Copy link
Member

zimbatm commented Mar 4, 2020

also cherry-picked into 20.03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants