Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.paperwm: init at 36.0 #81785

Merged
merged 1 commit into from Mar 11, 2020
Merged

gnomeExtensions.paperwm: init at 36.0 #81785

merged 1 commit into from Mar 11, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Mar 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @hedning @jtojnar @worldofpeace

@jtojnar jtojnar requested a review from hedning March 5, 2020 01:16
@hedning
Copy link
Contributor

hedning commented Mar 5, 2020

Note, I'll release paperwm-36.0 soon, which have gnome 3.36 support. But I guess it doesn't hurt to get this in.

@worldofpeace
Copy link
Contributor

@hedning Probably should add yourself as a maintainer of this package 😁

@hedning
Copy link
Contributor

hedning commented Mar 7, 2020

Yep, that's probably.

How do you push to PRs again (I now I've done it before, but seem to have forgotten)?

@zowoq
Copy link
Contributor Author

zowoq commented Mar 7, 2020

@hedning I've added you as a maintainer.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 7, 2020 •
edited

@hedning git push https://github.com/zowoq/nixpkgs.git HEAD:paperwm -f

Also if you use gitAndTool.gh the you can do gh pr checkout 81785 and just git push -f (it will set the remote for the branch correctly.

Might also need cli/cli#546 (comment)

@ofborg ofborg bot requested a review from hedning March 7, 2020 13:07
@hedning
Copy link
Contributor

hedning commented Mar 7, 2020

OK, I just released 36.0, lets start it there :)

@zowoq zowoq changed the title gnomeExtensions.paperwm: init at 34.3 gnomeExtensions.paperwm: init at 36.0 Mar 7, 2020
@zowoq
Copy link
Contributor Author

zowoq commented Mar 7, 2020

Updated to 36.0.

hedning
hedning approved these changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick sanity check that it runs in a nested gnome shell. LGTM at least 😆

@ofborg ofborg bot requested a review from hedning March 7, 2020 13:48
@rawkode
Copy link
Member

rawkode commented Mar 8, 2020

Lets get this merged! 😄

@rawkode
Copy link
Member

rawkode commented Mar 11, 2020

@hedning I think @NixOS/ofborg requested a review right after you reviewed this, could you approve this again and lets get it merged? :)

@hedning
Copy link
Contributor

hedning commented Mar 11, 2020

I'm happy to merge this myself, but thought I'd leave it to someone who's more impartial tbh.

@rawkode
Copy link
Member

rawkode commented Mar 11, 2020

@hedning I've approved it also, but no merge access.

@hedning hedning merged commit 982b4da into NixOS:master Mar 11, 2020
@hedning
Copy link
Contributor

hedning commented Mar 11, 2020

Cheers :)

@zowoq zowoq deleted the paperwm branch March 11, 2020 21:55
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 11, 2020
@zowoq @dtzWill
gnomeExtensions.paperwm: init at 36.0 (NixOS#81785)
0a6f7fc 
(cherry picked from commit 982b4da)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@rawkode rawkode rawkode approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zowoq @hedning @worldofpeace @jtojnar @rawkode