hdl.ir: Pick up the variable name as a default name for submodules #330
Conversation
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
=========================================
- Coverage 82.56% 82.46% -0.1%
=========================================
Files 35 35
Lines 5884 5908 +24
Branches 1196 1197 +1
=========================================
+ Hits 4858 4872 +14
- Misses 864 879 +15
+ Partials 162 157 -5
Continue to review full report at Codecov.
|
|
Unfortunately the current behavior exists for a reason: module names are semantically meaningful, and having two modules with the same name is not legal, unlike signals, where it's totally fine. Also, I think it's important that Have you considered, instead of using: submod = Submodule()
m.submodules += submoddoing: m.submodules.submod = submod = Submodule()That's the suggested syntax and it even has the same amount of typing. |
|
You mean that submodules should not be instanciated in __init__ ? |
|
They can be if it makes sense, then you'd do: m.submodules.submod = self.submodlater. |
The current generated rtlil uses name like U$$ for module names, which is not good for discoverability, implementing debuggers, etc. This patch picks up the variable name as default name for modules, in a similar way than is done for Signals.
I'm not sure what the rules for unicity are, if any. Maybe the name should include the hierarchy in it to avoid collisions. I'm not sure.