Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: 12.8.1 -> 12.8.2 #81803

Merged
1 commit merged into from Mar 5, 2020
Merged

gitlab: 12.8.1 -> 12.8.2 #81803

1 commit merged into from Mar 5, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Mar 5, 2020

This needs to be backported to 20.03 and 19.09

Includes multiple security fixes mentioned in
https://about.gitlab.com/releases/2020/03/04/gitlab-12-dot-8-dot-2-released/
(unfortunately, no CVE numbers as of yet)

  • Directory Traversal to Arbitrary File Read
  • Account Takeover Through Expired Link
  • Server Side Request Forgery Through Deprecated Service
  • Group Two-Factor Authentication Requirement Bypass
  • Stored XSS in Merge Request Pages
  • Stored XSS in Merge Request Submission Form
  • Stored XSS in File View
  • Stored XSS in Grafana Integration
  • Contribution Analytics Exposed to Non-members
  • Incorrect Access Control in Docker Registry via Deploy Tokens
  • Denial of Service via Permission Checks
  • Denial of Service in Design For Public Issue
  • GitHub Tokens Displayed in Plaintext on Integrations Page
  • Incorrect Access Control via LFS Import
  • Unescaped HTML in Header
  • Private Merge Request Titles Leaked via Widget
  • Project Namespace Exposed via Vulnerability Feedback Endpoint
  • Denial of Service Through Recursive Requests
  • Project Authorization Not Being Updated
  • Incorrect Permission Level For Group Invites
  • Disclosure of Private Group Epic Information
  • User IP Address Exposed via Badge images
  • Update postgresql (GitLab Omnibus)
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Includes multiple security fixes mentioned in
https://about.gitlab.com/releases/2020/03/04/gitlab-12-dot-8-dot-2-released/
(unfortunately, no CVE numbers as of yet)

 - Directory Traversal to Arbitrary File Read
 - Account Takeover Through Expired Link
 - Server Side Request Forgery Through Deprecated Service
 - Group Two-Factor Authentication Requirement Bypass
 - Stored XSS in Merge Request Pages
 - Stored XSS in Merge Request Submission Form
 - Stored XSS in File View
 - Stored XSS in Grafana Integration
 - Contribution Analytics Exposed to Non-members
 - Incorrect Access Control in Docker Registry via Deploy Tokens
 - Denial of Service via Permission Checks
 - Denial of Service in Design For Public Issue
 - GitHub Tokens Displayed in Plaintext on Integrations Page
 - Incorrect Access Control via LFS Import
 - Unescaped HTML in Header
 - Private Merge Request Titles Leaked via Widget
 - Project Namespace Exposed via Vulnerability Feedback Endpoint
 - Denial of Service Through Recursive Requests
 - Project Authorization Not Being Updated
 - Incorrect Permission Level For Group Invites
 - Disclosure of Private Group Epic Information
 - User IP Address Exposed via Badge images
 - Update postgresql (GitLab Omnibus)
@flokli
Copy link
Contributor Author

flokli commented Mar 5, 2020

@GrahamcOfBorg build gitlab
@GrahamcOfBorg test gitlab

@ofborg ofborg bot requested a review from ehmry March 5, 2020 06:12
@flokli flokli added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 5, 2020
Copy link
Contributor

@talyz talyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually without issues 👍

@ghost
Copy link

ghost commented Mar 5, 2020

I didn't backport 12.8.1 to 19.09, should 19.09 still get new major releases as well?

@ghost ghost merged commit c25756f into NixOS:master Mar 5, 2020
@flokli
Copy link
Contributor Author

flokli commented Mar 5, 2020

yes, we should still backport security releases to 19.09, I think we support older versions ~1 month after the release date of the current release.

@flokli flokli deleted the gitlab-12.8.2 branch March 5, 2020 15:42
ghost pushed a commit that referenced this pull request Mar 5, 2020
Includes multiple security fixes mentioned in
https://about.gitlab.com/releases/2020/03/04/gitlab-12-dot-8-dot-2-released/
(unfortunately, no CVE numbers as of yet)

 - Directory Traversal to Arbitrary File Read
 - Account Takeover Through Expired Link
 - Server Side Request Forgery Through Deprecated Service
 - Group Two-Factor Authentication Requirement Bypass
 - Stored XSS in Merge Request Pages
 - Stored XSS in Merge Request Submission Form
 - Stored XSS in File View
 - Stored XSS in Grafana Integration
 - Contribution Analytics Exposed to Non-members
 - Incorrect Access Control in Docker Registry via Deploy Tokens
 - Denial of Service via Permission Checks
 - Denial of Service in Design For Public Issue
 - GitHub Tokens Displayed in Plaintext on Integrations Page
 - Incorrect Access Control via LFS Import
 - Unescaped HTML in Header
 - Private Merge Request Titles Leaked via Widget
 - Project Namespace Exposed via Vulnerability Feedback Endpoint
 - Denial of Service Through Recursive Requests
 - Project Authorization Not Being Updated
 - Incorrect Permission Level For Group Invites
 - Disclosure of Private Group Epic Information
 - User IP Address Exposed via Badge images
 - Update postgresql (GitLab Omnibus)

(cherry-picked from commit c25756f)
ghost pushed a commit that referenced this pull request Mar 5, 2020
Includes multiple security fixes mentioned in
https://about.gitlab.com/releases/2020/03/04/gitlab-12-dot-8-dot-2-released/
(unfortunately, no CVE numbers as of yet)

 - Directory Traversal to Arbitrary File Read
 - Account Takeover Through Expired Link
 - Server Side Request Forgery Through Deprecated Service
 - Group Two-Factor Authentication Requirement Bypass
 - Stored XSS in Merge Request Pages
 - Stored XSS in Merge Request Submission Form
 - Stored XSS in File View
 - Stored XSS in Grafana Integration
 - Contribution Analytics Exposed to Non-members
 - Incorrect Access Control in Docker Registry via Deploy Tokens
 - Denial of Service via Permission Checks
 - Denial of Service in Design For Public Issue
 - GitHub Tokens Displayed in Plaintext on Integrations Page
 - Incorrect Access Control via LFS Import
 - Unescaped HTML in Header
 - Private Merge Request Titles Leaked via Widget
 - Project Namespace Exposed via Vulnerability Feedback Endpoint
 - Denial of Service Through Recursive Requests
 - Project Authorization Not Being Updated
 - Incorrect Permission Level For Group Invites
 - Disclosure of Private Group Epic Information
 - User IP Address Exposed via Badge images
 - Update postgresql (GitLab Omnibus)

(cherry-picked from commit c25756f)
@ghost
Copy link

ghost commented Mar 5, 2020

Backported to 20.03 in c174670
Backported to 19.09 in 3f97de1

@flokli
Copy link
Contributor Author

flokli commented Mar 5, 2020 via email

@talyz talyz added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 20, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants