Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/prometheus-mikrotik-exporter: init #81857

Merged
merged 2 commits into from Mar 6, 2020
Merged

nixos/prometheus-mikrotik-exporter: init #81857

merged 2 commits into from Mar 6, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Mar 6, 2020

Adds package and module for https://github.com/nshttpd/mikrotik-exporter

Motivation for this change

Some information is not exposed through SNMP:(

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata mmilata requested a review from WilliButz as a code owner March 6, 2020 01:23
@mmilata mmilata force-pushed the prometheus-mikrotik-exporter branch from eae5e26 to 8d24c26 Compare March 6, 2020 01:25
@ofborg ofborg bot requested a review from kalbasit March 6, 2020 01:39
@mmilata mmilata force-pushed the prometheus-mikrotik-exporter branch from 8d24c26 to 8a8fef4 Compare March 6, 2020 09:38
@mmilata mmilata force-pushed the prometheus-mikrotik-exporter branch from 8a8fef4 to 421a18f Compare March 6, 2020 09:39
@WilliButz
Copy link
Member

@GrahamcOfBorg test prometheus-exporters.mikrotik

@WilliButz WilliButz merged commit 3cd57cf into NixOS:master Mar 6, 2020
@mmilata mmilata deleted the prometheus-mikrotik-exporter branch March 6, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@WilliButz WilliButz WilliButz approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmilata @WilliButz @Ma27