nixos/prometheus-*-exporters: minor fixes #81854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allowed values have changed in bd3319d. 0.15: --log.level="info" Only log messages with the given severity or above. Valid levels: [debug, info, warn, error, fatal] --log.format="logger:stderr" Set the log target and format. Example: "logger:syslog?appname=bob&local=7" or "logger:stdout?json=true" 0.17: --log.level=info Only log messages with the given severity or above. One of: [debug, info, warn, error] --log.format=logfmt Output format of log messages. One of: [logfmt, json]
The assertion was printed when user explicitly defined only the configurationPath option.
The assertion was printed when user explicitly defined only the configFile option.
- Fix misspelled option. mkRenamedOptionModule is not used because the option hasn't really worked before. - Add missing cfg.telemetryPath arg to ExecStart. - Fix mkdir invocation in test.
WilliButz
approved these changes
Mar 6, 2020
WilliButz
added
the
8.has: port to stable
|
Thank you for the swift review & taking care of backporting! |
|
@WilliButz I realized that 20.03 has the older version of the SNMP exporter so now the module options mismatch those of the package. Should we revert 6673c4f or backport bd3319d? |
|
Oh, thanks for noticing. The exporter version bump should have already been backported. I'll do that in a moment. |
|
backported the exporter update in b417adb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing with Prometheus and the NixOS modules are very nice! Run into a few problems in the exporters which this PR fixes:
disableFileDelitionfor mail exporter is misspelled and has no effectconfigurationorconfigFileoptions do not work as intended, the assertion is triggered when user uses justconfigFileand doesn't touchconfigurationunifiPasswordcontaining space (or filesystem path w/ space, eww)Motivation for this change
NixOS prometheus experience only 98 % smooth.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @WilliButz