Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.batchgenerators: init at 0.19.7 #81739

Merged
merged 2 commits into from Mar 14, 2020
Merged

python3Packages.batchgenerators: init at 0.19.7 #81739

merged 2 commits into from Mar 14, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Mar 4, 2020 •
edited

python3Packages.threadpoolctl: init at 2.0.0

Motivation for this change

Add a package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin bcdarwin changed the title python3Packages.threadpoolctl: init at 2.0.0 python3Packages.batchgenerators: init at 0.19.7 Mar 4, 2020
@bcdarwin
Copy link
Member Author

bcdarwin commented Mar 6, 2020

@jonringer -- resolved, thanks.

jonringer
jonringer approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests 👍

https://github.com/NixOS/nixpkgs/pull/81739
4 package built:
python37Packages.batchgenerators python37Packages.threadpoolctl python38Packages.batchgenerators python38Packages.threadpoolctl

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.batchgenerators python37Packages.threadpoolctl python38Packages.batchgenerators python38Packages.threadpoolctl

@bcdarwin
Copy link
Member Author

bcdarwin commented Mar 7, 2020

python38Packages.numexpr is timing on out Darwin.

@FRidh FRidh merged commit 61b61ed into NixOS:master Mar 14, 2020
@bcdarwin bcdarwin deleted the threadpoolctl branch March 15, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @jonringer @FRidh