Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satallax: Fix build with GCC9 #81796

Merged
merged 1 commit into from Mar 8, 2020
Merged

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

Build was broken because GCC9 doesn't accept this declaration anymore.

Unfortunately upstream doesn't seem to continue developmente anymore :/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 merged commit 84f862e into NixOS:master Mar 8, 2020
@JohnAZoidberg JohnAZoidberg deleted the satallax-gcc9 branch March 8, 2020 15:17
@Ma27
Copy link
Member

Ma27 commented Mar 8, 2020

Thanks! Backported as aae661c.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants