New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvmPackages_10: rc2 -> rc3 #81819
llvmPackages_10: rc2 -> rc3 #81819
Conversation
@GrahamcOfBorg build llvmPackages_10 llvmPackages_10.clang-polly-unwrapped llvmPackages_10.clang-unwrapped |
Local build on Darwin
@DieGoldeneEnte maybe you can confirm this build error on Linux too? I am suspecting a linker bug. Or maybe it's not a linker bug, as I see:
Do we activate Polly the wrong way? Did the options change? Or is polly on by default now? Relevant: http://prereleases.llvm.org/10.0.0/rc3/tools/polly/docs/ReleaseNotes.html |
@Meinersbur may I reach out to you because of the above build error? llvm/llvm-project@d7afdb5 looks like a relevant commit for debugging this, but I am not knowledgeable enough about its mechanics. The major question is whether Polly is in |
I can confirm the same error on linux. |
I don't now what What cmake variables does |
Polly is built in the There were bugs with dylibs before. See llvm/llvm-project#120 |
The fixes llvm/llvm-project@3a0f6e6 and llvm/llvm-project@87dac7d are not cherry-picked into clang 10.0 because of the risk so short before the release. They should be in clang 10.0.1. If your package manager supports it, you could apply the patches locally. |
@Meinersbur Thanks for the hints! I have included the three relevant commits as patches to
How can I test whether the corresponding Looks like we are fine:
The non-polly flavour doesn't understand |
http://lists.llvm.org/pipermail/llvm-dev/2020-March/139729.html Additionally cherry-picked 3 commits from `llvm-project/master`: - llvm/llvm-project@d21664c - llvm/llvm-project@3a0f6e6 - llvm/llvm-project@87dac7d such that clang can automatically pick up the polly plugin from the `llvm-polly` build.
@DieGoldeneEnte PTAL, I think this is ready for merging. CC @basvandijk |
In course of moving to the git monorepository, LLVM changed the project layout from polly in the Since the the developers, including me, are using the monorepository layout, the subproject layout will be less-and-less tested, and I expect it to be removed at some point to simplify the build system. |
@ggreif LGTM. It compiles without problems and polly is only available for the polly-variant. |
Dito. Let's iterate. |
Ping @dtzWill @matthewbauer |
@GrahamcOfBorg build llvmPackages_10 llvmPackages_10.clang-polly-unwrapped llvmPackages_10.clang-unwrapped |
Motivation for this change
http://lists.llvm.org/pipermail/llvm-dev/2020-March/139729.html
Things done
s/rc2/rc3/g
llvm-project/master
:such that clang can automatically pick up the polly plugin from the
llvm-polly
build.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)